Run arrow tests for --lib and --tests on CI builds - #9814
Merged
Conversation
alamb
changed the title
Contributor
Author
|
A bunch of these tests take quite a bit of time: https://github.com/apache/arrow-rs/actions/runs/24918932041/job/72976578508?pr=9814 I could reduce overall CI time by splitting out a few of the runs. But I will wait to see if anyone has additonal thoughts about this approach before spending more time on that 
|
alamb
force-pushed
the
alamb/run_release_test
branch
from
April 25, 2026 01:20
79836cc to
e3b56a9
Compare
alamb
marked this pull request as ready for review
April 25, 2026 15:23
Jefffrey
approved these changes
Jun 3, 2026
Jefffrey
left a comment
Jefffrey
left a comment
Contributor
There was a problem hiding this comment.
7min more seems a drop in the bucket compared to the miri run anyway
Contributor
Author
Though @AdamGS is fixing the MIRI runs little by little 🤷 |
Contributor
Author
|
Thank you @Jefffrey |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
As noted in #9813 (comment), Rust debug builds panic on arithmetic overflow / underflow but release builds do not (they simply overflow / underflow). This means that some code paths may panic in debug builds that would have silently failed in release builds.
As we harden down the security posture of arrow-rs I would like to start testing in release mode too to ensure overflows such as #9813 can be properly validation
What changes are included in this PR?
Add Some new release mode tests:
linux-release-test:et alAre these changes tested?
They are only tests, no code changes
Are there any user-facing changes?
No